[ 
https://issues.apache.org/jira/browse/HDFS-11880?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16041714#comment-16041714
 ] 

Xiaoyu Yao commented on HDFS-11880:
-----------------------------------

Thanks [~nandakumar131] for the patch. The latest patch looks good to me. +1.
Only one minor javadoc issue: KsmBucketInfo.java line 94/110 that I will update 
at commit time.

I noticed that OzoneConsts.java is moved into hadoop-hdfs-client with this 
change. Some of the const are used only by KSM/SCM server. We might consider 
have a OzoneClientConsts.java for those client only constants. We can do that 
in a follow up JIRA. 



> Ozone: KSM: Remove protobuf formats such as StorageTypeProto and OzoneAclInfo 
> from KSM wrappers
> -----------------------------------------------------------------------------------------------
>
>                 Key: HDFS-11880
>                 URL: https://issues.apache.org/jira/browse/HDFS-11880
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: ozone
>    Affects Versions: HDFS-7240
>            Reporter: Nandakumar
>            Assignee: Nandakumar
>         Attachments: HDFS-11880-HDFS-7240.000.patch, 
> HDFS-11880-HDFS-7240.001.patch
>
>
> KSM wrappers like KsmBucketInfo and KsmBucketArgs are using protobuf formats 
> such as StorageTypeProto and OzoneAclInfo, this jira is to remove the 
> dependency and use {{StorageType}} and {{OzoneAcl}} instead.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

Reply via email to