[
https://issues.apache.org/jira/browse/HDFS-10480?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16043800#comment-16043800
]
Manoj Govindassamy edited comment on HDFS-10480 at 6/9/17 1:53 AM:
-------------------------------------------------------------------
Thanks for the review comments [~andrew.wang]. Attached v07 patch to address
the following. Please take a look.
bq. DFSAdmin, I'd prefer that we don't print a special message when there
aren't any open files. Just print the header with no entries.
Done.
bq. DFSAdmin help text needs an additional linebreak and tab to wrap the long
line in the output
Done.
bq. Thinking about it a little more, we can remove the HdfsAdmin API and make
the CLI the only public API. A number of DFSAdmin commands don't have
corresponding HdfsAdmin APIs (e.g. evictWriters, triggerBlockReport). We can
always add the Java API later if there's demand.
Given that this jira is very useful for debugging problems, I am anticipating
HdfsAdmin API demand from automation users who are already using the interface.
Unit tests are also added to verify the API. Inclined to retain it for it now.
There are also followup enhancements planned on top of this jira, and if any
need to be removed can be taken care later. Thanks.
was (Author: manojg):
Thanks for the review comments [~andrew.wang]. Attached v07 patch to address
the following. Please take a look.
bq. DFSAdmin, I'd prefer that we don't print a special message when there
aren't any open files. Just print the header with no entries.
Done.
bq. DFSAdmin help text needs an additional linebreak and tab to wrap the long
line in the output
Done.
Bq. Thinking about it a little more, we can remove the HdfsAdmin API and make
the CLI the only public API. A number of DFSAdmin commands don't have
corresponding HdfsAdmin APIs (e.g. evictWriters, triggerBlockReport). We can
always add the Java API later if there's demand.
Given that this jira is very useful for debugging problems, I am anticipating
HdfsAdmin API demand from automation users who are already using the interface.
Unit tests are also added to verify the API. Inclined to retain it for it now.
There are also followup enhancements planned on top of this jira, and if any
need to be removed can be taken care later. Thanks.
> Add an admin command to list currently open files
> -------------------------------------------------
>
> Key: HDFS-10480
> URL: https://issues.apache.org/jira/browse/HDFS-10480
> Project: Hadoop HDFS
> Issue Type: Improvement
> Reporter: Kihwal Lee
> Assignee: Manoj Govindassamy
> Attachments: HDFS-10480.02.patch, HDFS-10480.03.patch,
> HDFS-10480.04.patch, HDFS-10480.05.patch, HDFS-10480.06.patch,
> HDFS-10480.07.patch, HDFS-10480-trunk-1.patch, HDFS-10480-trunk.patch
>
>
> Currently there is no easy way to obtain the list of active leases or files
> being written. It will be nice if we have an admin command to list open files
> and their lease holders.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
