[ 
https://issues.apache.org/jira/browse/HDFS-12054?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16067834#comment-16067834
 ] 

lufei commented on HDFS-12054:
------------------------------

[~jojochuang], thanks for your time to review.I have checked all the kind of  
WRITE EC operations(the kind of READ EC operations may not need to check the 
namenode whether in safemode), there only exist two operations lack this 
check.Except function of addECPolicies in this issue,the function of  
FSNamesystem#removeErasureCodingPolicy may also need to do this check.But I 
have already created another issue(HDFS-12066) to trace the function of 
removeErasureCodingPolicy. 

> FSNamesystem#addECPolicies should call checkNameNodeSafeMode() to ensure 
> Namenode is not in safemode
> ----------------------------------------------------------------------------------------------------
>
>                 Key: HDFS-12054
>                 URL: https://issues.apache.org/jira/browse/HDFS-12054
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: hdfs
>    Affects Versions: 3.0.0-alpha3
>            Reporter: lufei
>            Assignee: lufei
>              Labels: hdfs-ec-3.0-nice-to-have
>         Attachments: HDFS-12054.001.patch
>
>
> In the process of FSNamesystem#addECPolicies, it would be better to  call 
> checkNameNodeSafeMode() to ensure NN is not in safemode.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

Reply via email to