[
https://issues.apache.org/jira/browse/HDFS-10391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16069964#comment-16069964
]
Gergely Novák commented on HDFS-10391:
--------------------------------------
Thank you [~xyao] for your review!
Based on your suggestions in the latest patch (#008) I
- modified the description of dfs.namenode.servicerpc-address in
hdfs-default.xml
- removed the fallback to RPC bind host from NamenodeRpcServer
- introduced globalTimeout in TestDataNodeMetricsLogger
As for your other comments:
- "can we add some test with/wo service rpc/rpc binding host?" I think this is
still properly covered by
TestNameNodeRespectsBindHostKeys.testServiceRpcBindHostKey(). Maybe add one
additional test case there where we don't set the
dfs.namenode.servicerpc-address explicitly?
- I'm not confident about the other two comments regarding the
NamenodeRpcServer. [~arpitagarwal] could you please address them?
> Always enable NameNode service RPC port
> ---------------------------------------
>
> Key: HDFS-10391
> URL: https://issues.apache.org/jira/browse/HDFS-10391
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: datanode, namenode
> Reporter: Arpit Agarwal
> Assignee: Gergely Novák
> Labels: Incompatible
> Attachments: HDFS-10391.001.patch, HDFS-10391.002.patch,
> HDFS-10391.003.patch, HDFS-10391.004.patch, HDFS-10391.005.patch,
> HDFS-10391.006.patch, HDFS-10391.007.patch, HDFS-10391.008.patch,
> HDFS-10391.v5-v6-delta.patch
>
>
> The NameNode should always be setup with a service RPC port so that it does
> not have to be explicitly enabled by an administrator.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
