[
https://issues.apache.org/jira/browse/HDFS-12069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16079945#comment-16079945
]
Yuanbo Liu commented on HDFS-12069:
-----------------------------------
[~cheersyang] Thanks for your patch.
when you commit, please fix the check warning.
LevelDBStore.java
Line 218
{code}
ImmutablePair<byte[], byte[]> kv = new ImmutablePair<>(current.getKey(),
current.getValue());
{code}
others look good to me.
Thoughts:
LevelDBStore#iterate
It seems we can refactor some code if Consumer#accept has a boolean return,
then we can use it like
{code}
while(...) {
if(! Consumer#accept()) {
break;
}
}
{code}
> Ozone: Create a general abstraction for metadata store
> ------------------------------------------------------
>
> Key: HDFS-12069
> URL: https://issues.apache.org/jira/browse/HDFS-12069
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: ozone
> Reporter: Weiwei Yang
> Assignee: Weiwei Yang
> Attachments: HDFS-12069-HDFS-7240.001.patch,
> HDFS-12069-HDFS-7240.002.patch, HDFS-12069-HDFS-7240.003.patch,
> HDFS-12069-HDFS-7240.004.patch, HDFS-12069-HDFS-7240.005.patch,
> HDFS-12069-HDFS-7240.006.patch, HDFS-12069-HDFS-7240.007.patch,
> HDFS-12069-HDFS-7240.008.patch, HDFS-12069-HDFS-7240.009.patch
>
>
> Create a general abstraction for metadata store so that we can plug other key
> value store to host ozone metadata. Currently only levelDB is implemented, we
> want to support RocksDB as it provides more production ready features.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
