[ 
https://issues.apache.org/jira/browse/HDFS-12026?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16080283#comment-16080283
 ] 

Anatoli Shein commented on HDFS-12026:
--------------------------------------

Thank you for the feedback [~aw].

I agree that we should not require both gcc and clang for building the native 
components, and also agree that the hardcoded /usr/bin paths need to be fixed. 
This was just the first patch where I tried forcing the clang build and testing 
it to see where it would fail :)

I think the actual way we should try to do this is to detect the default 
compiler in the environment and use it for the build, and only use both 
compilers (gcc and clang) during CI.

I also definitely agree that we should try and get this branch up to speed with 
trunk as soon as possible since we have been putting this off for too long.

> libhdfs++: Fix compilation errors and warnings when compiling with Clang 
> -------------------------------------------------------------------------
>
>                 Key: HDFS-12026
>                 URL: https://issues.apache.org/jira/browse/HDFS-12026
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: hdfs-client
>            Reporter: Anatoli Shein
>            Assignee: Anatoli Shein
>         Attachments: HDFS-12026.HDFS-8707.000.patch, 
> HDFS-12026.HDFS-8707.001.patch, HDFS-12026.HDFS-8707.002.patch, 
> HDFS-12026.HDFS-8707.003.patch, HDFS-12026.HDFS-8707.004.patch, 
> HDFS-12026.HDFS-8707.005.patch, HDFS-12026.HDFS-8707.006.patch
>
>
> Currently multiple errors and warnings prevent libhdfspp from being compiled 
> with clang. It should compile cleanly using flags:
> -std=c++11 -stdlib=libc++
> and also warning flags:
> -Weverything -Wno-c++98-compat -Wno-missing-prototypes 
> -Wno-c++98-compat-pedantic -Wno-padded -Wno-covered-switch-default 
> -Wno-missing-noreturn -Wno-unknown-pragmas -Wconversion -Werror



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

Reply via email to