[ https://issues.apache.org/jira/browse/HDFS-12152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16090075#comment-16090075 ]
Rakesh R commented on HDFS-12152: --------------------------------- Attached a simple fix. Sets interrupt flag to true so that {{Future<BlockMovementResult> future = moverCompletionService.take();}} will get {{InterruptedException}}. Otw, the thread will enter into indefinite wait and resulting constant 3 secs thread joining period. > [SPS]: Re-arrange StoragePolicySatisfyWorker stopping sequence to improve > thread cleanup time > --------------------------------------------------------------------------------------------- > > Key: HDFS-12152 > URL: https://issues.apache.org/jira/browse/HDFS-12152 > Project: Hadoop HDFS > Issue Type: Sub-task > Components: datanode, namenode > Reporter: Rakesh R > Assignee: Rakesh R > Priority: Minor > Attachments: HDFS-12152-HDFS-10285-01.patch > > > This jira to improve the StoragePolicySatisfyWorker#stop sequence of steps to > improve the thread interruption and graceful shutdown quickly. > I have observed that > [TestDataNodeUUID#testUUIDRegeneration|https://builds.apache.org/job/PreCommit-HDFS-Build/20271/testReport/org.apache.hadoop.hdfs.server.datanode/TestDataNodeUUID/testUUIDRegeneration/] > test case is getting timed out frequently. When analyzing, it looks like the > below function is always taking 3 secs waiting period. Probably, we could > improve the thread interruption sequence so that the thread should finish > #run method quickly. > {code} > StoragePolicySatisfyWorker.java > void waitToFinishWorkerThread() { > try { > movementTrackerThread.join(3000); > } catch (InterruptedException ignore) { > // ignore > } > } > {code} -- This message was sent by Atlassian JIRA (v6.4.14#64029) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org