[ 
https://issues.apache.org/jira/browse/HDFS-12149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16094153#comment-16094153
 ] 

Yuanbo Liu commented on HDFS-12149:
-----------------------------------

[~cheersyang] Thanks for your patch, these are my comments:
LevelDBStore.java
line 165: use close method instead
{code}
close();
....
{code}
line 128, check null point before closing db
{code}
if(db != null) {
  db.close();
}
{code}

RocksDBStore.java
line 237: use close method instead
{code}
close();
{code}

line 267: I don't have much experience in RocksDB, what if iterator doesn't 
have next or prev?


> Ozone: RocksDB implementation of ozone metadata store
> -----------------------------------------------------
>
>                 Key: HDFS-12149
>                 URL: https://issues.apache.org/jira/browse/HDFS-12149
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: ozone
>            Reporter: Weiwei Yang
>            Assignee: Weiwei Yang
>         Attachments: HDFS-12149-HDFS-7240.001.patch, 
> HDFS-12149-HDFS-7240.002.patch
>
>
> HDFS-12069 added a general interface for ozone metadata store, we already 
> have a leveldb implementation, this JIRA is to track the work of rocksdb 
> implementation.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

Reply via email to