[ 
https://issues.apache.org/jira/browse/HDFS-11896?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16095409#comment-16095409
 ] 

Konstantin Shvachko commented on HDFS-11896:
--------------------------------------------

The patches look really good. But some test failures are definitely related to 
the change. I was looking at TestDecommissioningStatus. Did not get into 
details, but it looks like {{adminState}} is getting wiped out for dead nodes, 
while dead nodes should remain decommissioned after death.
[~brahmareddy], so if you say it's harder to fix, we can go back to your 
previous patch for trunk, and file a followup jira for code reuse? I may have 
proposed a too radical change.

> Non-dfsUsed will be doubled on dead node re-registration in branch-2.7.
> -----------------------------------------------------------------------
>
>                 Key: HDFS-11896
>                 URL: https://issues.apache.org/jira/browse/HDFS-11896
>             Project: Hadoop HDFS
>          Issue Type: Bug
>    Affects Versions: 2.7.3
>            Reporter: Brahma Reddy Battula
>            Assignee: Brahma Reddy Battula
>              Labels: release-blocker
>         Attachments: HDFS-11896-002.patch, HDFS-11896-003.patch, 
> HDFS-11896-branch-2.7-001.patch, HDFS-11896-branch-2.7-002.patch, 
> HDFS-11896-branch-2.7-003.patch, HDFS-11896.patch
>
>
>  *Scenario:* 
> i)Make you sure you've non-dfs data.
> ii) Stop Datanode
> iii) wait it becomes dead
> iv) now restart and check the non-dfs data



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

Reply via email to