[ 
https://issues.apache.org/jira/browse/HDFS-12145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16097350#comment-16097350
 ] 

Weiwei Yang commented on HDFS-12145:
------------------------------------

Hi [~msingh]

Thanks for the update, but I was meant to say that we could add an argument for 
{{PutHelper}} so it can put a specific key name, such as

{code}
PutHelper(OzoneRestClient client, String dir, String keyName);
{code}

Then in test {{testPutKey()}}, we could add

{code}
runTestPutKey(new PutHelper(ozoneRestClient,
    path, OzoneUtils.getRequestID().toLowerCase()));
runTestPutKey(new PutHelper(ozoneRestClient,
    path, getRandomKeyDelimitedBy("/")));
{code}

so that we can test both delimited and non-delimited keys.
Here I think we can rename {{getMultiPartKey()}} to 
{{getRandomKeyDelimitedBy()}}, this method allows you to get a key name with a 
specific delimiter.

{code}
String getRandomKeyDelimitedBy(String delimiter);
{code}

Does that make sense to you? Please let me know. 
Thanks a lot.

> Ozone: OzoneFileSystem: Ozone & KSM should support "/" delimited key names
> --------------------------------------------------------------------------
>
>                 Key: HDFS-12145
>                 URL: https://issues.apache.org/jira/browse/HDFS-12145
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: ozone
>    Affects Versions: HDFS-7240
>            Reporter: Mukul Kumar Singh
>            Assignee: Mukul Kumar Singh
>             Fix For: HDFS-7240
>
>         Attachments: HDFS-12145-HDFS-7240.001.patch, 
> HDFS-12145-HDFS-7240.002.patch, HDFS-12145-HDFS-7240.003.patch, 
> HDFS-12145-HDFS-7240.004.patch
>
>
> With OzoneFileSystem, key names will be delimited by "/" which is used as the 
> path separator.
> Support should be added in KSM and Ozone to support key name with "/"



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

Reply via email to