[ https://issues.apache.org/jira/browse/HDFS-11580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16108555#comment-16108555 ]
Nandakumar commented on HDFS-11580: ----------------------------------- Thanks [~anu] for the explanation and patch. The patch looks good to me, below are some minor comments Instead of having two calls {{sendCommand}} and {{sendCommandAsync}} in {{XceiverClientHandler}}, we can have single {{XceiverClientHandler#sendCommand}} which is by default asynchronous and we can make {{XceiverClient#sendCommand}} call into {{XceiverClient#sendCommandAsync(request).get()}} which will make the call synchronous. NIT: XceiverClientHandler:120 typo in "completed" NIT: XceiverClient :126-130 indentation > Ozone: Support asynchronus client API for SCM and containers > ------------------------------------------------------------ > > Key: HDFS-11580 > URL: https://issues.apache.org/jira/browse/HDFS-11580 > Project: Hadoop HDFS > Issue Type: Sub-task > Components: ozone > Affects Versions: HDFS-7240 > Reporter: Anu Engineer > Assignee: Yiqun Lin > Attachments: HDFS-11580-HDFS-7240.001.patch, > HDFS-11580-HDFS-7240.002.patch, HDFS-11580-HDFS-7240.003.patch, > HDFS-11580-HDFS-7240.004.patch, HDFS-11580-HDFS-7240.005.patch, > HDFS-11580-HDFS-7240.006.patch, HDFS-11580-HDFS-7240.007.patch, > HDFS-11580-HDFS-7240.008.patch, HDFS-11580-HDFS-7240.009.patch, > HDFS-11580-HDFS-7240.010.patch, HDFS-11580-HDFS-7240.011.patch, > HDFS-11580-HDFS-7240.012.patch > > > This is an umbrella JIRA that needs to support a set of APIs in Asynchronous > form. > For containers -- or the datanode API currently supports a call > {{sendCommand}}. we need to build proper programming interface and support an > async interface. > There is also a set of SCM API that clients can call, it would be nice to > support Async interface for those too. -- This message was sent by Atlassian JIRA (v6.4.14#64029) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org