[ https://issues.apache.org/jira/browse/HDFS-5040?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16110753#comment-16110753 ]
Brahma Reddy Battula commented on HDFS-5040: -------------------------------------------- [~kshukla] thanks for updating the patch. 1.looks you missed to give {{operationName}} for {{rollEditLog}} {code} 4519 writeUnlock(); {code} 2. Add {{fail}} assertion for exception cases. you can use {{ContractTestUtils.fail}} 3. Use {{GenericTestUtils.assertExceptionContains}} for asserting the messages 4. looks all the tests are failing (may some problem with my env..?),will wait for jenkin results. > Audit log for admin commands/ logging output of all DFS admin commands > ---------------------------------------------------------------------- > > Key: HDFS-5040 > URL: https://issues.apache.org/jira/browse/HDFS-5040 > Project: Hadoop HDFS > Issue Type: New Feature > Components: namenode > Affects Versions: 3.0.0-alpha1 > Reporter: Raghu C Doppalapudi > Assignee: Kuhu Shukla > Labels: BB2015-05-TBR > Attachments: HDFS-5040.001.patch, HDFS-5040.004.patch, > HDFS-5040.patch, HDFS-5040.patch, HDFS-5040.patch > > > enable audit log for all the admin commands/also provide ability to log all > the admin commands in separate log file, at this point all the logging is > displayed on the console. -- This message was sent by Atlassian JIRA (v6.4.14#64029) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org