[ https://issues.apache.org/jira/browse/HDFS-10899?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16113844#comment-16113844 ]
Xiao Chen commented on HDFS-10899: ---------------------------------- Thanks a lot for managing your time to get to this, [~daryn]. I will go through the patch and make sure the suggestions are applied. A few clarifications: bq. Why can't a file with a re-encrypting EDEK be renamed? Details were added to HDFS-11203's description. Basically we can't guarantee re-encryption doesn't miss any renames easily. Can we further discuss on that jira, to keep our focuses? bq. tracking via path components v.s. via inodes (also replied in HDFS-11203 but likes some clarification). Tracking inodes would work, but that means we have to go from ROOT_INODE_ID to the biggest inodeid, no matter what the EZ is, right? It makes sense if the EZ is {{/}}, but if it's a small EZ, we don't want to iterate all inodes. Please elaborate if I misunderstood. bq. bullet points from the spiel Thanks a lot for the advice! I think all of those were considered, except for {{Sending more edits than can be buffered without a sync will cause a sync while holding the write lock}}. I will carefully look at this. For a quick reference, the batch size defaults to 1000. Will get more numbers from different aspects about performance, I want everyone's gut kept safe :) Quick question, what tool did you use to blast the NN? Is it sharable? > Add functionality to re-encrypt EDEKs > ------------------------------------- > > Key: HDFS-10899 > URL: https://issues.apache.org/jira/browse/HDFS-10899 > Project: Hadoop HDFS > Issue Type: New Feature > Components: encryption, kms > Reporter: Xiao Chen > Assignee: Xiao Chen > Attachments: editsStored, HDFS-10899.01.patch, HDFS-10899.02.patch, > HDFS-10899.03.patch, HDFS-10899.04.patch, HDFS-10899.05.patch, > HDFS-10899.06.patch, HDFS-10899.07.patch, HDFS-10899.08.patch, > HDFS-10899.09.patch, HDFS-10899.10.patch, HDFS-10899.10.wip.patch, > HDFS-10899.11.patch, HDFS-10899.12.patch, HDFS-10899.wip.2.patch, > HDFS-10899.wip.patch, Re-encrypt edek design doc.pdf, Re-encrypt edek design > doc V2.pdf > > > Currently when an encryption zone (EZ) key is rotated, it only takes effect > on new EDEKs. We should provide a way to re-encrypt EDEKs after the EZ key > rotation, for improved security. -- This message was sent by Atlassian JIRA (v6.4.14#64029) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org