[ https://issues.apache.org/jira/browse/HDFS-1969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13038765#comment-13038765 ]
Konstantin Shvachko commented on HDFS-1969: ------------------------------------------- I think originally test were written under the assumption that VERSION file is the same for all versions. It is not anymore, so I agree with you we should have special methods generating version file, somewhere in UpgradeUtilities. I am not against Guava or the vote, I just think it is strange to introduce a new package dependency just for one line, which to me looks like a classic assert. > Running rollback on new-version namenode destroys namespace > ----------------------------------------------------------- > > Key: HDFS-1969 > URL: https://issues.apache.org/jira/browse/HDFS-1969 > Project: Hadoop HDFS > Issue Type: Bug > Components: name-node > Affects Versions: 0.22.0 > Reporter: Todd Lipcon > Assignee: Todd Lipcon > Priority: Blocker > Fix For: 0.22.0 > > Attachments: hdfs-1969.txt, hdfs-1969.txt > > > The following sequence leaves the namespace in an inconsistent/broken state: > - format NN using 0.20 (or any prior release, probably) > - run hdfs namenode -upgrade on 0.22. ^C the NN once it comes up. > - run hdfs namenode -rollback on 0.22 (this should fail but doesn't!) > This leaves the name directory in a state such that the version file claims > it's an 0.20 namespace, but the fsimage is in 0.22 format. It then crashes > when trying to start up. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira