[
https://issues.apache.org/jira/browse/HDFS-6939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16117482#comment-16117482
]
Ming Ma commented on HDFS-6939:
-------------------------------
Yeah we can include this feature if it provides values. Couple questions:
* Each RPC getEditsFromTxid call ends up sending the filter over the wire; so
filter with lots of paths has perf impact. Do we need to support large number
of paths per call?
* In the future there could be other type of filters, e.g. a) based on
FsEditLogOp type; b) support different logical operators OR, AND, etc. To make
it extensible, perhaps we can define an interface with signature
shouldNotify(FsEditLogOp) and provide the path-based PathBasedInotifyFilter for
now. Then InotifyFSEditLogOpTranslator will be simpler by checking shouldNotify
upfront; if we need to add path-and-editop-based filtering, we can just add
PathAndOpBasedInotifyFilter without changing InotifyFSEditLogOpTranslator.
* DFSClient's existing getInotifyEventStream methods are only used by
DistributedFileSystem. So you don't need to keep these old methods on
DFSClient; instead have DistributedFileSystem's old getInotifyEventStream
methods call DFSClient's new methods. Also maybe we can consider depreciate
DistributedFileSystem's old getInotifyEventStream methods.
> Support path-based filtering of inotify events
> ----------------------------------------------
>
> Key: HDFS-6939
> URL: https://issues.apache.org/jira/browse/HDFS-6939
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: hdfs-client, namenode, qjm
> Reporter: James Thomas
> Assignee: Surendra Singh Lilhore
> Attachments: HDFS-6939-001.patch
>
>
> Users should be able to specify that they only want events involving
> particular paths.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
