[ https://issues.apache.org/jira/browse/HDFS-12054?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16121929#comment-16121929 ]
Wei-Chiu Chuang edited comment on HDFS-12054 at 8/10/17 5:20 PM: ----------------------------------------------------------------- Thanks for the new patch. As a minor improvement, would you please also add an additional statement after {code} ns.addErasureCodingPolicies(policyArray); {code} just to make sure it throws exception in safe mode? {code} fail("AddECPolicyResponse should have failed."); {code} Also, since the scope of patch is small and similar, this jira could be consolidated with HDFS-12066, to avoid repeated reviews and updates. was (Author: jojochuang): Thanks for the new patch. As a minor improvement, would you please also add an additional statement after {code} ns.addErasureCodingPolicies(policyArray); {code} just to make sure it throws exception in safe mode? {code} fail("AddECPolicyResponse should have failed."); {code} > FSNamesystem#addErasureCodingPolicies should call checkNameNodeSafeMode() to > ensure Namenode is not in safemode > --------------------------------------------------------------------------------------------------------------- > > Key: HDFS-12054 > URL: https://issues.apache.org/jira/browse/HDFS-12054 > Project: Hadoop HDFS > Issue Type: Bug > Components: hdfs > Affects Versions: 3.0.0-alpha3 > Reporter: lufei > Assignee: lufei > Labels: hdfs-ec-3.0-nice-to-have > Attachments: HDFS-12054.001.patch, HDFS-12054.002.patch, > HDFS-12054.003.patch > > > In the process of FSNamesystem#addErasureCodingPolicies, it would be better > to call checkNameNodeSafeMode() to ensure NN is not in safemode. -- This message was sent by Atlassian JIRA (v6.4.14#64029) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org