[
https://issues.apache.org/jira/browse/HDFS-12258?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16127002#comment-16127002
]
Rakesh R commented on HDFS-12258:
---------------------------------
Thanks [~zhouwei] for the patch. Following are few comments, please take care.
# Typo: {{Diabled}} -> {{Disabled}}
{code}
/**
* EC policy state.
*/
enum ErasureCodingPolicyState {
Diabled = 1;
{code}
# Please use captial letters.
{{ErasureCodingPolicyState#Disabled, #Enabled, #Removed}} ==>
{{ErasureCodingPolicyState#DISABLED, #ENABLED, #REMOVED}}
# Please add annotation to enum state
{code}
@InterfaceAudience.Public
@InterfaceStability.Evolving
public enum ErasureCodingPolicyState
{code}
# {{ErasureCodingPolicyManager#addPolicy(ErasureCodingPolicy policy)}} function
is not considering the state. What if user sets {{ErasureCodingPolicy#state}}
and invoked {{dfs#addErasureCodingPolicies()}} API?
> ec -listPolicies should list all policies in system, no matter it's enabled
> or disabled
> ---------------------------------------------------------------------------------------
>
> Key: HDFS-12258
> URL: https://issues.apache.org/jira/browse/HDFS-12258
> Project: Hadoop HDFS
> Issue Type: Improvement
> Reporter: SammiChen
> Assignee: Wei Zhou
> Labels: hdfs-ec-3.0-must-do
> Attachments: HDFS-12258.01.patch, HDFS-12258.02.patch
>
>
> ec -listPolicies should list all policies in system, no matter it's enabled
> or disabled
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
