[ 
https://issues.apache.org/jira/browse/HDFS-12309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16129414#comment-16129414
 ] 

ASF GitHub Bot commented on HDFS-12309:
---------------------------------------

GitHub user dosoft opened a pull request:

    https://github.com/apache/hadoop/pull/264

    HDFS-12309. Fixed incorrect checkNotNull()

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/dosoft/hadoop HDFS-12309

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/hadoop/pull/264.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #264
    
----
commit cd77a28bb7826d0cc77da365f21cd05f9fade7e0
Author: Oleg Danilov <o...@olegd.com>
Date:   2017-08-16T21:04:47Z

    HDFS-12309. Fixed incorrect checkNotNull()

----


> Incorrect null check in the AdminHelper.java
> --------------------------------------------
>
>                 Key: HDFS-12309
>                 URL: https://issues.apache.org/jira/browse/HDFS-12309
>             Project: Hadoop HDFS
>          Issue Type: Bug
>            Reporter: Oleg Danilov
>            Priority: Trivial
>
> '!= null' is not required there:
> line 147-150:
> {code:java}
>     public HelpCommand(Command[] commands) {
>       Preconditions.checkNotNull(commands != null);
>       this.commands = commands;
>     }
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

Reply via email to