[ 
https://issues.apache.org/jira/browse/HDFS-11988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16133849#comment-16133849
 ] 

Lei (Eddy) Xu commented on HDFS-11988:
--------------------------------------

One nit:

{code}
602: Assert.assertEquals("Snap3 and before truncate file checksum should 
match!",
        hbaseFileCksumBeforeTruncate, hbaseFileCksumS3);
{code}

is this line duplicated with line 571?

+1 pending after fixing this.  Thanks [~manojg]

> Verify HDFS Snapshots with open files captured are safe across truncates and 
> appends on current version file
> ------------------------------------------------------------------------------------------------------------
>
>                 Key: HDFS-11988
>                 URL: https://issues.apache.org/jira/browse/HDFS-11988
>             Project: Hadoop HDFS
>          Issue Type: Test
>          Components: hdfs, snapshots
>    Affects Versions: 3.0.0-alpha1
>            Reporter: Manoj Govindassamy
>            Assignee: Manoj Govindassamy
>         Attachments: HDFS-11988.01.patch
>
>
> With HDFS-11402 fix, open files can also be captured in the snapshots as 
> point-in-time copies. This jira is for adding more unit tests to verify the 
> correctness of the snapshot files using checksums when the current version of 
> the file is truncated and appended after the snapshot time.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

Reply via email to