[ 
https://issues.apache.org/jira/browse/HDFS-12292?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16136484#comment-16136484
 ] 

Mukul Kumar Singh commented on HDFS-12292:
------------------------------------------

Thanks for the updated patch [~erofeev], 

1) DFSAdmin.java:126, Should the condition inside the if statement should be 
changed to ViewFileSystem ?
As this line contradicts the if statement on 130.

2) PathData.java:321 and 325, I feel that line 325 will always be true when 321 
is true. Can one of these conditions be avoided ?

3) PathData.java:325, should there be a check for filesystem scheme here?

> Federation: Support viewfs:// schema path for DfsAdmin commands
> ---------------------------------------------------------------
>
>                 Key: HDFS-12292
>                 URL: https://issues.apache.org/jira/browse/HDFS-12292
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: federation
>            Reporter: Mikhail Erofeev
>            Assignee: Mikhail Erofeev
>         Attachments: HDFS-12292-002.patch, HDFS-12292-003.patch, 
> HDFS-12292-004.patch, HDFS-12292.patch
>
>
> Motivation:
> As of now, clients need to specify a nameservice when a cluster is federated, 
> otherwise, the exception is fired:
> {code}
> hdfs dfsadmin -setQuota 10 viewfs://vfs-root/user/uname
> setQuota: FileSystem viewfs://vfs-root/ is not an HDFS file system
> # with fs.defaultFS = viewfs://vfs-root/
> hdfs dfsadmin -setQuota 10 vfs-root/user/uname
> setQuota: FileSystem viewfs://vfs-root/ is not an HDFS file system
> # works fine thanks to https://issues.apache.org/jira/browse/HDFS-11432
> hdfs dfsadmin -setQuota 10 hdfs://users-fs/user/uname
> {code}
> This creates inconvenience, inability to rely on fs.defaultFS and forces to 
> create client-side mappings for management scripts
> Implementation:
> PathData that is passed to commands should be resolved to its actual 
> FileSystem
> Result:
> ViewFS will be resolved to the actual HDFS file system



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

Reply via email to