[
https://issues.apache.org/jira/browse/HDFS-12354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16144688#comment-16144688
]
Yiqun Lin commented on HDFS-12354:
----------------------------------
Thanks for the review, [~cheersyang]!
bq. Can we just maintain prefix and prevKey internally in an implementation
class (if necessary) instead of exposing them via arguments? Want to keep the
method simple to call.
I agree with this. Addressed.
bq. Can we use int type count?
Addressed.
bq. in ozone-default.xml, can we add some more doc here
Addressed.
Attach the updated patch.
> Ozone: Shuffle container list for datanode BlockDeletingService
> ---------------------------------------------------------------
>
> Key: HDFS-12354
> URL: https://issues.apache.org/jira/browse/HDFS-12354
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: datanode, ozone
> Reporter: Weiwei Yang
> Assignee: Yiqun Lin
> Attachments: HDFS-12354-HDFS-7240.001.patch,
> HDFS-12354-HDFS-7240.002.patch
>
>
> {{BlockDeletingService}} is a per-datanode container block deleting service
> takes in charge of the "real" deletion of ozone blocks. It spawns a worker
> thread per container and delete blocks/chunks from disk as background
> threads. The number of threads currently is throttled by
> {{ozone.block.deleting.container.limit.per.interval}}, but there is a
> potential problem. Containers are sorted so it always fetch same of
> containers, we need to fix this by creating an API in
> {{ContainerManagerImpl}} to get a shuffled list of containers.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
