[
https://issues.apache.org/jira/browse/HDFS-1934?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13039888#comment-13039888
]
Jakob Homan commented on HDFS-1934:
-----------------------------------
This semantic was argued out in HDFS-538, where it was agreed that in general
empty collections or arrays should be returned for directories/whatever with no
contents, exceptions should be thrown for invalid/non-existent requests and
null should never be returned. Glancing at the latest patch, I see some hard
tabs and some odd spacing.
> Fix NullPointerException when certain File APIs return null
> -----------------------------------------------------------
>
> Key: HDFS-1934
> URL: https://issues.apache.org/jira/browse/HDFS-1934
> Project: Hadoop HDFS
> Issue Type: Bug
> Affects Versions: 0.23.0
> Reporter: Bharath Mundlapudi
> Assignee: Bharath Mundlapudi
> Fix For: 0.23.0
>
> Attachments: HDFS-1934-1.patch, HDFS-1934-2.patch
>
>
> While testing Disk Fail Inplace, We encountered the NPE from this part of the
> code.
> File[] files = dir.listFiles();
> for (File f : files) {
> ...
> }
> This is kinda of an API issue. When a disk is bad (or name is not a
> directory), this API (listFiles, list) return null rather than throwing an
> exception. This 'for loop' throws a NPE exception. And same applies to
> dir.list() API.
> Fix all the places where null condition was not checked.
>
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
