[
https://issues.apache.org/jira/browse/HDFS-12268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16149612#comment-16149612
]
Chen Liang commented on HDFS-12268:
-----------------------------------
Thanks [~linyiqun] for the patch. v004 patch looks good to me overall. Some
minor comments:
1. I found this sentence in {{OzoneMetrics.md}} a bit difficult to understand
"This is the metric for the client that container operations haven't been
processed by container server." Maybe rephrase this a little bit?
2. Seems to me that {{TestXceiverClientMetrics#testMetrics}} L117 and L121 two
assertions may not always hold. Because it seems to me that it is possible that
if the machine is fast enough, async calls could have finished at this point.
Maybe having another thread that keeps making async calls and got killed after
the assertion?
> Ozone: Add metrics for pending storage container requests
> ---------------------------------------------------------
>
> Key: HDFS-12268
> URL: https://issues.apache.org/jira/browse/HDFS-12268
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: ozone
> Affects Versions: HDFS-7240
> Reporter: Yiqun Lin
> Assignee: Yiqun Lin
> Attachments: HDFS-12268-HDFS-7240.001.patch,
> HDFS-12268-HDFS-7240.002.patch, HDFS-12268-HDFS-7240.003.patch,
> HDFS-12268-HDFS-7240.004.patch
>
>
> As storage container async interface has been supported after HDFS-11580, we
> need to keep an eye on the queue depth of pending container requests. It can
> help us better found if there are some performance problems.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
