[ 
https://issues.apache.org/jira/browse/HDFS-12384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16150081#comment-16150081
 ] 

Sean Busbey commented on HDFS-12384:
------------------------------------

Ah. The correct solution is to update the exclusions that determine which 
shaded artifact the new classes go into; they should only go into one. If a 
downstream client needs the curator classes in order to interact with HDFS, 
then they should only be in the hadoop-client-runtime (which would mean 
updating the pom for hadoop-client-minicluster to exclude them).

You can see an example of excluding all of the curator-client from 
hadoop-client-minicluster:

https://github.com/apache/hadoop/blob/ce797a170669524224cfeaaf70647047e7626816/hadoop-client-modules/hadoop-client-minicluster/pom.xml#L137

If you need to just exclude some specific classes then take a look at the set 
of filters:

https://github.com/apache/hadoop/blob/ce797a170669524224cfeaaf70647047e7626816/hadoop-client-modules/hadoop-client-minicluster/pom.xml#L603

> Fixing compilation issue with BanDuplicateClasses
> -------------------------------------------------
>
>                 Key: HDFS-12384
>                 URL: https://issues.apache.org/jira/browse/HDFS-12384
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: fs
>            Reporter: Íñigo Goiri
>            Assignee: Íñigo Goiri
>             Fix For: HDFS-10467
>
>         Attachments: HDFS-12384-HDFS-10467-000.patch
>
>
> {{hadoop-client-modules}} is failing because of dependences added by 
> {{CuratorManager}}:
> {code}
> [INFO]   Adding ignore: *
> [WARNING] Rule 1: org.apache.maven.plugins.enforcer.BanDuplicateClasses 
> failed with message:
> Duplicate classes found:
>   Found in:
>     
> org.apache.hadoop:hadoop-client-minicluster:jar:3.0.0-beta1-SNAPSHOT:compile
>     org.apache.hadoop:hadoop-client-runtime:jar:3.0.0-beta1-SNAPSHOT:compile
>   Duplicate classes:
>     
> org/apache/hadoop/shaded/org/apache/curator/framework/api/DeleteBuilder.class
>     
> org/apache/hadoop/shaded/org/apache/curator/framework/CuratorFramework.class
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

Reply via email to