[
https://issues.apache.org/jira/browse/HDFS-12395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16155177#comment-16155177
]
SammiChen commented on HDFS-12395:
----------------------------------
Thanks [~rakeshr] for the quick review!
bq. I could see CacheEntry and CacheEntryWithPayload used in the patch. Is it
intentionally used differently for different cases?
My understanding is CacheEntryWithPayload is used for API which has return
object. CacheEntry is used fro API without return value.
bq. Can we move checkOperation() and checkNameNodeSafeMode() checks outside
for loop. If it throws exception, then #addErasureCodingPolicies() operation
won't be atomic anyway, right? Atomic op, I meant either API should consider
all policies and shouldn't add policies partially.
It's a good suggestion to move checkOperation() and checkNameNodeSafeMode()
checks outside for loop. For addErasureCodingPolicies API itself, atomic is not
a goal.
All other comments will be addressed in next patch.
> Support add, remove, disable and enable erasure coding policy operations in
> edit log
> ------------------------------------------------------------------------------------
>
> Key: HDFS-12395
> URL: https://issues.apache.org/jira/browse/HDFS-12395
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: erasure-coding
> Reporter: SammiChen
> Assignee: SammiChen
> Labels: hdfs-ec-3.0-must-do
> Attachments: HDFS-12395.001.patch
>
>
> Support add, remove, disable, enable erasure coding policy operation in edit
> log.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
