[
https://issues.apache.org/jira/browse/HDFS-1954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13041910#comment-13041910
]
Patrick Hunt commented on HDFS-1954:
------------------------------------
Hey, to make my suggestion more concrete I put together a patch that show's
what I'm getting at:
1) limited annoyance - a link to some help (ie the faq entry, which doesn't
currently exist but say it did). This gives new users some concrete help,
advanced users can easily ignore it, and we're not duplicating any detail that
rightly belongs on the faq page.
2) note I also included Konstantin's suggestion.
{noformat}
--- src/java/org/apache/hadoop/hdfs/server/namenode/NamenodeJspHelper.java
+++ src/java/org/apache/hadoop/hdfs/server/namenode/NamenodeJspHelper.java
@@ -155,13 +155,10 @@ class NamenodeJspHelper {
// Warning class is typically displayed in RED
result.append("<br/><a class=\"warning\" href=\"/corrupt_files.jsp\"
title=\"List corrupt files\">\n");
result.append("<b>WARNING : There are " + missingBlocks
- + " missing blocks. Please check the log or run fsck.</b>");
+ + " missing blocks. Please check the logs or run fsck in order to
identify the missing blocks.</b>");
result.append("</a>");
- result.append("<br/><div class=\"small\">Hint: A common
mis-configuration is not ");
- result.append("overriding \"" + DFSConfigKeys.DFS_DATANODE_DATA_DIR_KEY
- + "\" on all datanodes");
- result.append("(the default is typically /tmp which is not
persistent)</div>");
+ result.append("<br/><div class=\"small\">See this <a
href=\"http:hadoop.apache.org/some_FAQ_page.html#someQandAEntry\">FAQ</a> entry
for common causes and potential solutions.");
result.append("<br/><br/>\n");
return result.toString();
{noformat}
LMK if that makes more sense, of if I'm way off.
> Improve corrupt files warning message
> -------------------------------------
>
> Key: HDFS-1954
> URL: https://issues.apache.org/jira/browse/HDFS-1954
> Project: Hadoop HDFS
> Issue Type: Improvement
> Reporter: philo vivero
> Assignee: Patrick Hunt
> Fix For: 0.22.0
>
> Attachments: HDFS-1954.patch, HDFS-1954.patch
>
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> On NameNode web interface, you may get this warning:
> WARNING : There are about 32 missing blocks. Please check the log or run
> fsck.
> If the cluster was started less than 14 days before, it would be great to
> add: "Is dfs.data.dir defined?"
> If at the point of that error message, that parameter could be checked, and
> error made "OMG dfs.data.dir isn't defined!" that'd be even better. As is,
> troubleshooting undefined parameters is a difficult proposition.
> I suspect this is an easy fix.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
