[
https://issues.apache.org/jira/browse/HDFS-12486?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16174025#comment-16174025
]
Bharat Viswanadham commented on HDFS-12486:
-------------------------------------------
[~hanishakoneru] Thanks for your comment and offline discussion.
1. The previous code patch is also using InetSocketAddress. I think it is okay
here to continue with Util#getAddressesList and reuse the existing function.
2. The check is added because if user called hdfs getConf -journalnodes and qjm
is not setup to return empty value for user and this also helps in start-dfs.sh
and stop-dfs.sh (when dfs.namenode.shared.edits.dir is set with shared storage)
As now start-dfs.sh and stop-dfs.sh logic is changed in HDFS-12375 jira.
addressed other review comments.
> GetConf to get journalnodeslist
> -------------------------------
>
> Key: HDFS-12486
> URL: https://issues.apache.org/jira/browse/HDFS-12486
> Project: Hadoop HDFS
> Issue Type: Improvement
> Reporter: Bharat Viswanadham
> Assignee: Bharat Viswanadham
> Attachments: HDFS-12486.01.patch, HDFS-12486.02.patch,
> HDFS-12486.03.patch, HDFS-12486.04.patch
>
>
> GetConf command to list journal nodes.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
