[ https://issues.apache.org/jira/browse/HDFS-12257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16175935#comment-16175935 ]
Mukul Kumar Singh commented on HDFS-12257: ------------------------------------------ Thanks for the patch [~HuafengWang], the patch looks good to me. Some minor nitpicks:a) TestHdfsAdmin:197,199: the assertTrue statements can be fit into a single line, b) checkstyle issue becaue of the patch. > Expose getSnapshottableDirListing as a public API in HdfsAdmin > -------------------------------------------------------------- > > Key: HDFS-12257 > URL: https://issues.apache.org/jira/browse/HDFS-12257 > Project: Hadoop HDFS > Issue Type: Improvement > Components: snapshots > Affects Versions: 2.6.5 > Reporter: Andrew Wang > Assignee: Huafeng Wang > Attachments: HDFS-12257.001.patch > > > Found at HIVE-16294. We have a CLI API for listing snapshottable dirs, but no > programmatic API. Other snapshot APIs are exposed in HdfsAdmin, I think we > should expose listing there as well. -- This message was sent by Atlassian JIRA (v6.4.14#64029) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org