[
https://issues.apache.org/jira/browse/HDFS-12060?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16185697#comment-16185697
]
Nandakumar edited comment on HDFS-12060 at 9/29/17 11:14 AM:
-------------------------------------------------------------
Thanks [~xyao] for the review. updated patch v003 adressing review comments.
bq. Do we need to update the KSM CLI to use these new list APIs for better
performance?
Once HDFS-12549 is done, I will create a new jira to make all the {{oz}}
commands to use new API. we have HDFS-12550 to track the removal of old Rest
client.
bq. At interface level, I would like to have a maxListResult as a parameter to
the API instead of assuming ozone.key.cache.size. This applies to the other
list APIs as well.
APIs have been changed.
bq. prevKey should be prevBucket
Done
bq. Do we limit the maximum number bucket returned per listBuckets call with
ozone.key.cache.size?
Yeah, we do. Updated the javadoc
bq. we should use the UGI#getShortUserName()
Thanks for the catch. fixed it in new patch.
bq. If we could make the change in the API with the additional parameter, we
will use the ozone.key.cache.size only if the maxListResult is not specified.
Now maxListResult is a mandatory parameter, we use {{ozone.client.list.cache}}
in {{ObjectStore}}, {{OzoneVolume}} and {{OzoneBucket}} to calculate
maxListResult.
was (Author: nandakumar131):
Thanks [~xyao] for the review. updated patch v003 adressing review comments.
bq. Do we need to update the KSM CLI to use these new list APIs for better
performance?
Once HDFS-12549 is done, I will create a new jira to make all the {{oz}}
commands to use new API. we have HDFS-12550 to track the removal of old Rest
client.
bq. At interface level, I would like to have a maxListResult as a parameter to
the API instead of assuming ozone.key.cache.size. This applies to the other
list APIs as well.
APIs have been changed.
bq. prevKey should be prevBucket
Done
bq. Do we limit the maximum number bucket returned per listBuckets call with
ozone.key.cache.size?
Yeah, we do. Updated the javadoc
bq. we should use the UGI#getShortUserName()
Thanks for the catch. fixed it in new patch.
bq. If we could make the change in the API with the additional parameter, we
will use the ozone.key.cache.size only if the maxListResult is not specified.
Now maxListResult is a mandatory parameter, we use {{ozone.key.cache.size}} in
{{ObjectStore}}, {{OzoneVolume}} and {{OzoneBucket}} to calculate maxListResult.
> Ozone: OzoneClient: Add list calls in RpcClient
> -----------------------------------------------
>
> Key: HDFS-12060
> URL: https://issues.apache.org/jira/browse/HDFS-12060
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Reporter: Nandakumar
> Assignee: Nandakumar
> Labels: ozoneMerge
> Attachments: HDFS-12060-HDFS-7240.000.patch,
> HDFS-12060-HDFS-7240.001.patch, HDFS-12060-HDFS-7240.002.patch,
> HDFS-12060-HDFS-7240.003.patch
>
>
> Support for {{listVolumes}}, {{listBuckets}}, {{listKeys}} in {{RpcClient}}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
