[ 
https://issues.apache.org/jira/browse/HDFS-12514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16188384#comment-16188384
 ] 

Rushabh S Shah commented on HDFS-12514:
---------------------------------------

bq. This is related to what HDFS-10627 and HDFS-7686. Rushabh S Shah, Colin P. 
McCabe, opinions on this?
[~elgoiri] The list of exceptions to be ignored seems  good to me.

I have one minor comment on the patch.
{noformat}
+          // WSAECONNABORTED
+          "An established connection was aborted by the software in your " +
+              "host machine",
{noformat}
I haven't developed on Windows environment so this comment might not make sense.
>From the following windows documentation 
>https://msdn.microsoft.com/en-us/library/windows/desktop/ms740668(v=vs.85).aspx
it says,
|WSAECONNABORTED| 10053 |Software caused connection abort.
An established connection was aborted by the software in your host computer, 
possibly due to a data transmission time-out or protocol error.|

Will the exception message start with {{An established connection was aborted}} 
or {{Software caused connection abort.}}
If it does starts with {{An established connection was aborted by the software 
in your host machine}}, then check the last few words in documentation.
It is {{host computer}}. But in the patch it is {{host machine}} so the 
{{String#startsWith(prefix)}} will fail.




> Cancelled HedgedReads cause block to be marked as suspect on Windows
> --------------------------------------------------------------------
>
>                 Key: HDFS-12514
>                 URL: https://issues.apache.org/jira/browse/HDFS-12514
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: datanode, hdfs-client
>            Reporter: Lukas Majercak
>            Assignee: Lukas Majercak
>         Attachments: HDFS-12514.001.patch
>
>
> DFSClient with hedged reads enabled will often close previous spawned 
> connections if it successfully reads from one of them. This can result in 
> DataNode's BlockSender getting a socket exception and wrongly marking the 
> block as suspect and to be rescanned for errors.
> This patch is aimed at adding windows specific network related exception 
> messages to be ignored in BlockSender.sendPacket.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

Reply via email to