[
https://issues.apache.org/jira/browse/HDFS-12570?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16192915#comment-16192915
]
Surendra Singh Lilhore commented on HDFS-12570:
-----------------------------------------------
Thanks [~rakeshr] for patch...
I looked at the patch. Following are my comment in my first look.
# In
{{BlockStorageMovementAttemptedItems#blockStorageMovementReportedItemsCheck()}},
if {{attemptedItemInfo.allBlockLocsAttemptedToSatisfy}} is false then we
should add {{ItemInfo}} back to the {{blockStorageMovementNeeded}} queue.
# FSNamesystem#handleHeartbeat() : Correct the log message, now are not using
"co-ordinator datanode".
{code}
if (LOG.isDebugEnabled()) {
LOG.debug(
"Storage policy satisfier is not running. So, ignoring block "
+ "storage movement results sent by co-ordinator datanode");
}
{code}
# Can we try to use IBR instead of adding new parameter
{{BlocksStorageMoveAttemptFinished}} in {{NameNodeRpcServer#sendHeartbeat()}} ?.
> [SPS]: Refactor Co-ordinator datanode logic to track the block storage
> movements
> --------------------------------------------------------------------------------
>
> Key: HDFS-12570
> URL: https://issues.apache.org/jira/browse/HDFS-12570
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: datanode, namenode
> Reporter: Rakesh R
> Assignee: Rakesh R
> Attachments: HDFS-12570-HDFS-10285-00.patch
>
>
> This task is to refactor the C-DN block storage movements. Basically, the
> idea is to move the scheduling and tracking logic to Namenode rather than at
> the special C-DN. Please refer the discussion with [~andrew.wang] to
> understand the [background and the necessity of
> refactoring|https://issues.apache.org/jira/browse/HDFS-10285?focusedCommentId=16141060&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16141060].
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
