[ 
https://issues.apache.org/jira/browse/HDFS-12582?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16194066#comment-16194066
 ] 

Bharat Viswanadham edited comment on HDFS-12582 at 10/6/17 3:06 AM:
--------------------------------------------------------------------

Uploaded patch v03 to fix checkstyle issues.

Not resolved these checkstyle issues which are not from this change.


{code:java}
./hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/protocol/HdfsFileStatus.java:84:
  protected HdfsFileStatus(long length, boolean isdir, int 
block_replication,:13: More than 7 parameters (found 17). [ParameterNumber]
./hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/protocol/HdfsFileStatus.java:84:
  protected HdfsFileStatus(long length, boolean isdir, int 
block_replication,:60: Name 'block_replication' must match pattern 
'^[a-z][a-zA-Z0-9]*$'. [ParameterName]
{code}



was (Author: bharatviswa):
Uploaded patch v03 to fix checkstyle issues.

Not resolved these checkstyle issues which are not from this change.

{noformat}
./hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/protocol/HdfsFileStatus.java:84:
  protected HdfsFileStatus(long length, boolean isdir, int 
block_replication,:13: More than 7 parameters (found 17). [ParameterNumber]
./hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/protocol/HdfsFileStatus.java:84:
  protected HdfsFileStatus(long length, boolean isdir, int 
block_replication,:60: Name 'block_replication' must match pattern 
'^[a-z][a-zA-Z0-9]*$'. [ParameterName]
{noformat}


> Replace HdfsFileStatus constructor with a builder pattern.
> ----------------------------------------------------------
>
>                 Key: HDFS-12582
>                 URL: https://issues.apache.org/jira/browse/HDFS-12582
>             Project: Hadoop HDFS
>          Issue Type: Bug
>            Reporter: Bharat Viswanadham
>            Assignee: Bharat Viswanadham
>         Attachments: HDFS-12582.01.patch, HDFS-12582.02.patch, 
> HDFS-12582.03.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

Reply via email to