[
https://issues.apache.org/jira/browse/HDFS-12411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16194548#comment-16194548
]
Yuanbo Liu commented on HDFS-12411:
-----------------------------------
[~xyao] Thanks for filing this JIRA, I have some comments about your latest
patch:
1. ContainerData.java line 49
Can we rename the size as maxSize, it's a bit confusing.
2. ContainerReport.java
I've seen a lot of representing classes which only contain getters and setters,
I'm wondering whether these classes are really useful since we could use
protobuf classes instead. I'd prefer to abandon this kind of classes but I'm
opening on this point.
3.OzoneConfigKeys.java line 159
Can we add this parameter into ozone-default.xml?
4. I saw some refactor changes in your patch, can we file another JIRA to
address it. But I'm good if you want to keep those changes.
> Ozone: Add container usage information to DN container report
> -------------------------------------------------------------
>
> Key: HDFS-12411
> URL: https://issues.apache.org/jira/browse/HDFS-12411
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: ozone, scm
> Reporter: Xiaoyu Yao
> Assignee: Xiaoyu Yao
> Labels: ozoneMerge
> Attachments: HDFS-12411-HDFS-7240.001.patch,
> HDFS-12411-HDFS-7240.002.patch, HDFS-12411-HDFS-7240.003.patch,
> HDFS-12411-HDFS-7240.004.patch, HDFS-12411-HDFS-7240.005.patch
>
>
> Current DN ReportState for container only has a counter, we will need to
> include individual container usage information so that SCM can
> * close container when they are full
> * assign container for block service with different policies.
> * etc.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
