[
https://issues.apache.org/jira/browse/HDFS-12588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16206975#comment-16206975
]
Weiwei Yang commented on HDFS-12588:
------------------------------------
Hi [~elek]
Thanks for working on this. I have a few comments to the v3 patch, in
{{KeySpaceManager}}
line 193: can we move this line to be after line 202? In case parser fails, we
don't need to log the startup message as it will not be started at all
line 200, this prints the generic command usage, a lot of args but KSM doesn't
support yet, is it a bit confusing? Can we revise the usage message to be more
specific?
same comments apply to {{StorageContainerManager}} as well.
Thanks
> Use GenericOptionsParser for scm and ksm daemon
> -----------------------------------------------
>
> Key: HDFS-12588
> URL: https://issues.apache.org/jira/browse/HDFS-12588
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Affects Versions: HDFS-7240
> Reporter: Elek, Marton
> Assignee: Elek, Marton
> Attachments: HDFS-12588-HDFS-7240.001.patch,
> HDFS-12588-HDFS-7240.002.patch, HDFS-12588-HDFS-7240.003.patch
>
>
> Most of the hadoop commands use the GenericOptionsParser to use some common
> CLI arguments (such as -conf or -D or -libjars to define configuration/modify
> configuration/modify classpath).
> I suggest to use the same common options to scm and ksm daemons as well, as:
> 1. It allows to use the existing cluster management tools/scripts as the
> daemons could be configured in the same way as namenode and datanode
> 2. It follows the convention from the hadoop common.
> 3. It's easier to develop from the IDE (I start the ksm/scm/datanode/namenode
> from intellij but I need to add the configuration to the classpath. With
> -conf I would able to use external configration.)
> I found one problem during the implementation. Until now we used `hdfs scm`
> command both for the daemon and the scm command line client. If there were no
> parameters the daemon is started, with parameters the cli is started. The
> help listed only the damon.
> The -conf (GenericOptionParser) could be used only if we separate the scm and
> scmcli commands. But any way, it's a more clean and visible if we have
> separated `hdfs scm` and `hdfs scmcli`.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
