[
https://issues.apache.org/jira/browse/HDFS-11467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16213677#comment-16213677
]
Xiao Chen commented on HDFS-11467:
----------------------------------
Thanks for working on this [~HuafengWang], and others for reviewing. Patch
looks good in general, some comments:
- {{PBHelperClient.convertErasureCodingPolicyFully}}: is this added to persist
{{ErasueCodingPolicyState}}? HDFS-12682 / HDFS-12686 would take care of this if
so.
- We need fuller test cases. Suggest to look at the cases in HDFS-12395 and
apply similar coverage here. Looks to me we need: add->enable, enable->disable,
and some combinations with remove. From fsimage's perspective this sounds
indifferent than some simpler cases, but in the past we have seen issues where
some operations are handled by edits, but not fsimage. So I think better
coverage is safer.
- Let's not touch {{TestOfflineImageViewerForAcl}} for cleanness.
> Support ErasureCoding section in OIV XML/ReverseXML
> ---------------------------------------------------
>
> Key: HDFS-11467
> URL: https://issues.apache.org/jira/browse/HDFS-11467
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: tools
> Affects Versions: 3.0.0-alpha4
> Reporter: Wei-Chiu Chuang
> Assignee: Huafeng Wang
> Priority: Blocker
> Labels: hdfs-ec-3.0-must-do
> Attachments: HDFS-11467.001.patch, HDFS-11467.002.patch
>
>
> As discussed in HDFS-7859, after ErasureCoding section is added into fsimage,
> we would like to also support exporting this section into an XML back and
> forth using the OIV tool.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
