[ https://issues.apache.org/jira/browse/HDFS-12502?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16215374#comment-16215374 ]
Daryn Sharp commented on HDFS-12502: ------------------------------------ [~zhz], this is an incompatible change and I'd like it reverted. Adding a new operation is fine but conflating op counts with things in an op is not. This change will break a graph visualizer we use for the nntop data. I understand the motivation here, and perhaps the data can be captured elsewhere, but these metrics are named {{NNTopUserOpCounts}}, not {{NNTopUserOpCountsAndSometimesOtherValuesThatAreNotCountedIntheTotal}}. > nntop should support a category based on FilesInGetListingOps > ------------------------------------------------------------- > > Key: HDFS-12502 > URL: https://issues.apache.org/jira/browse/HDFS-12502 > Project: Hadoop HDFS > Issue Type: Improvement > Components: metrics > Reporter: Zhe Zhang > Assignee: Zhe Zhang > Fix For: 2.9.0, 2.8.3, 2.7.5, 3.0.0, 3.1.0 > > Attachments: HDFS-12502.00.patch, HDFS-12502.01.patch, > HDFS-12502.02.patch, HDFS-12502.03.patch, HDFS-12502.04.patch > > > Large listing ops can oftentimes be the main contributor to NameNode > slowness. The aggregate cost of listing ops is proportional to the > {{FilesInGetListingOps}} rather than the number of listing ops. Therefore > it'd be very useful for nntop to support this category. -- This message was sent by Atlassian JIRA (v6.4.14#64029) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org