[
https://issues.apache.org/jira/browse/HDFS-12720?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16222443#comment-16222443
]
Nanda kumar commented on HDFS-12720:
------------------------------------
[~msingh], thanks for finding the issue and working on it. The patch is not
applying anymore, can you rebase and upload a new one.
Please find my initial comments,
ContainerStateManager.java
line 413: Is there any reason for this change?
RatisManagerImpl.java
line 41: Unused import
line 131: Why are we constructing a new pipeline objects? Can't we use the same
object returned by {{findOpenPipeline(replicationFactor)}}
Is there any reason for moving the below code from {{allocateRatisPipeline}} to
{{getPipeline}}?
{code}
// Start all pipeline names with "Ratis", easy to grep the logs.
String pipelineName = PREFIX +
UUID.randomUUID().toString().substring(PREFIX.length());
{code}
RpcClient.java
I understand the reason for having {{verifyRatisReplication}}, we can change it
to {{getKsmKeyInfo}} and do the actual verification in the test case.
The following is not related to this patch:
Do we need container name in Pipeline?
A single pipeline can be used by more than one container, in that case, it
doesn't make sense to have container name in the pipeline.
> Ozone: Ratis options are not passed from KSM Client protobuf helper correctly.
> ------------------------------------------------------------------------------
>
> Key: HDFS-12720
> URL: https://issues.apache.org/jira/browse/HDFS-12720
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: ozone
> Affects Versions: HDFS-7240
> Reporter: Mukul Kumar Singh
> Assignee: Mukul Kumar Singh
> Labels: ozoneMerge
> Fix For: HDFS-7240
>
> Attachments: HDFS-12720-HDFS-7240.001.patch,
> HDFS-12720-HDFS-7240.002.patch
>
>
> {{KeySpaceManagerProtocolClientSideTranslatorPB#allocateBlock}} and
> {{KeySpaceManagerProtocolClientSideTranslatorPB#openKey}} do not pass the
> ratis replication factor and replication type to the KSM server. this causes
> the allocations using ratis model to resort to standalone mode even when
> Ratis mode is specified.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
