[
https://issues.apache.org/jira/browse/HDFS-12474?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16225705#comment-16225705
]
Xiaoyu Yao edited comment on HDFS-12474 at 10/30/17 9:54 PM:
-------------------------------------------------------------
Thanks [~nandakumar131] for working on it. The patch looks good to me overall.
In addition to [~linyiqun]'s comment, I just have few more comments below.
TestContainerMapping.java
Need to update the reference to BlockContainerInfo since the class is removed
with the patch. Otherwise, maven failed to build.
ContainerMapping.java
NIT: Line 27-33 unused imports
Line 356-363: if we always update the allocated based on the reported usage,
should we restrict the size to be smaller than
The maximum container size (5gb)?
SCMConfiguureKeys.java
Line 226-231: document the new configuration key for
ozone.scm.container.close.threshold.percentage in ozone-default.xml?
Please file follow up JIRAs to persist the contain allocated size and async
handling of the container report.
was (Author: xyao):
Thanks [~nandakumar131] for working on it. The patch looks good to me overall.
In addition to [~linyiqun]'s comment, I just have few more comments below.
ContainerMapping.java
NIT: Line 27-33 unused imports
Line 356-363: if we always update the allocated based on the reported usage,
should we restrict the size to be smaller than
The maximum container size (5gb)?
SCMConfiguureKeys.java
Line 226-231: document the new configuration key for
ozone.scm.container.close.threshold.percentage in ozone-default.xml?
Please file follow up JIRAs to persist the contain allocated size and async
handling of the container report.
> Ozone: SCM: Handling container report with key count and container usage.
> -------------------------------------------------------------------------
>
> Key: HDFS-12474
> URL: https://issues.apache.org/jira/browse/HDFS-12474
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Affects Versions: HDFS-7240
> Reporter: Xiaoyu Yao
> Assignee: Nanda kumar
> Labels: ozoneMerge
> Attachments: HDFS-12474-HDFS-7240.000.patch
>
>
> Currently, the container report only contains the # of reports sent to SCM.
> We will need to provide the key count and the usage of each individual
> containers to update the SCM container state maintained by
> ContainerStateManager. This has a dependency on HDFS-12387.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
