[ https://issues.apache.org/jira/browse/HDFS-12756?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Anu Engineer updated HDFS-12756: -------------------------------- Attachment: HDFS-12756-HDFS-7240.002.patch [~nandakumar131] & [~xyao] Thanks for the comments. bq. Just a small query, using DatanodeUUID String will have less memory footprint on RPC calls, is there any reason for not using DatanodeIDProto instead? yes bq. NIT: XceiverClientHandler:143 Typo in distinguish Fixed. bq. Is there a reason that we make the datanodeID optional here but make datanodeID required I have made it required. Plus, I have done some code refactoring which makes this patch larger. > Ozone: Add datanodeID to heartbeat responses and container protocol > ------------------------------------------------------------------- > > Key: HDFS-12756 > URL: https://issues.apache.org/jira/browse/HDFS-12756 > Project: Hadoop HDFS > Issue Type: Sub-task > Reporter: Anu Engineer > Assignee: Anu Engineer > Attachments: HDFS-12756-HDFS-7240.001.patch, > HDFS-12756-HDFS-7240.002.patch > > > if we have datanode ID in the HBs responses and commands send to datanode, we > will be able to do additional sanity checking on datanode before executing > the command. This is also very helpful in creating a MiniOzoneCluster with > 1000s of simulated nodes. This is needed for scale based unit tests of SCM. -- This message was sent by Atlassian JIRA (v6.4.14#64029) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org