[ https://issues.apache.org/jira/browse/HDFS-1619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13045206#comment-13045206 ]
Eli Collins commented on HDFS-1619: ----------------------------------- This patch does not remove the c99 requirement, we decided against *introducing it* in this thread. This patch just removes the AC_TYPE defines, which we should do because we already get these in the current code via stdint (per the docs "The Gnulib stdint module is an *alternate* way to define many of these symbols"). However, I agree we should compile with c99 since libhdfs uses some c99 features, I'll file a separate jira for that. > Does libhdfs really need to depend on AC_TYPE_INT16_T, AC_TYPE_INT32_T, > AC_TYPE_INT64_T and AC_TYPE_UINT16_T ? > -------------------------------------------------------------------------------------------------------------- > > Key: HDFS-1619 > URL: https://issues.apache.org/jira/browse/HDFS-1619 > Project: Hadoop HDFS > Issue Type: Improvement > Components: libhdfs > Reporter: Roman Shaposhnik > Assignee: Roman Shaposhnik > Fix For: 0.22.0 > > Attachments: HDFS-1619-C99.patch.txt, HDFS-1619.patch.txt, > hdfs-1619-2.patch > > > Currently configure.ac uses AC_TYPE_INT16_T, AC_TYPE_INT32_T, AC_TYPE_INT64_T > and AC_TYPE_UINT16_T and thus requires autoconf 2.61 or higher. > This prevents using it on such platforms as CentOS/RHEL 5.4 and 5.5. Given > that those are pretty popular and also given that it is really difficult to > find a platform > these days that doesn't natively define intXX_t types I'm curious as to > whether we can simply remove those macros or perhaps fail ONLY if we happen > to be on such > a platform. > Here's a link to GNU autoconf docs for your reference: > http://www.gnu.org/software/hello/manual/autoconf/Particular-Types.html -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira