[
https://issues.apache.org/jira/browse/HDFS-12808?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16250277#comment-16250277
]
Íñigo Goiri commented on HDFS-12808:
------------------------------------
I think it makes more sense to start migrating to sl4j and use something like:
{code}
LOG.debug("got fadvise(offset={}, len={},flags={})", offset, len, flags);
{code}
Not sure what is the situation on using the sl4j {{Logger}} but in trunk it
should be fine.
> Add LOG.isDebugEnabled() guard for LOG.debug("...")
> ---------------------------------------------------
>
> Key: HDFS-12808
> URL: https://issues.apache.org/jira/browse/HDFS-12808
> Project: Hadoop HDFS
> Issue Type: Improvement
> Reporter: Mehran Hassani
> Assignee: Bharat Viswanadham
> Priority: Minor
>
> I am conducting research on log related bugs. I tried to make a tool to fix
> repetitive yet simple patterns of bugs that are related to logs. In this
> file, there is a debug level logging statement containing multiple string
> concatenation without the if statement before them:
> hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/TestCachingStrategy.java,
> LOG.debug("got fadvise(offset=" + offset + ", len=" + len +",flags=" + flags
> + ")");, 82
> Would you be interested in adding the if, to the logging statement?
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
