[ https://issues.apache.org/jira/browse/HDFS-2003?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13045954#comment-13045954 ]
Ivan Kelly commented on HDFS-2003: ---------------------------------- Fixed the reading of blocks so that replication is adjusted before use. While it may not be strictly necessary, it's could introduce a real bug in the future, so its best to set the replication correctly from the outset. https://issues.apache.org/jira/secure/attachment/12481812/HDFS-2003.diff is the same as http://issues.apache.org/jira/secure/attachment/12481764/hdfs-2003.txt with HDFS-2003-replicationfix-delta.diff applied. > Separate FSEditLog reading logic from editLog memory state building logic > ------------------------------------------------------------------------- > > Key: HDFS-2003 > URL: https://issues.apache.org/jira/browse/HDFS-2003 > Project: Hadoop HDFS > Issue Type: Improvement > Affects Versions: Edit log branch (HDFS-1073) > Reporter: Ivan Kelly > Assignee: Ivan Kelly > Fix For: Edit log branch (HDFS-1073) > > Attachments: 2003-delta.txt, HDFS-2003-replicationfix-delta.diff, > HDFS-2003.diff, HDFS-2003.diff, HDFS-2003.diff, HDFS-2003.diff, > HDFS-2003.diff, HDFS-2003.diff, hdfs-2003.txt, hdfs-2003.txt, hdfs-2003.txt > > > Currently FSEditLogLoader has code for reading from an InputStream > interleaved with code which updates the FSNameSystem and FSDirectory. This > makes it difficult to read an edit log without having a whole load of other > object initialised, which is problematic if you want to do things like count > how many transactions are in a file etc. > This patch separates the reading of the stream and the building of the memory > state. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira