[
https://issues.apache.org/jira/browse/HDFS-12813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16256439#comment-16256439
]
Tsz Wo Nicholas Sze commented on HDFS-12813:
--------------------------------------------
Patch looks good. However, the existing code does not. Some
comments/questions:
- Let's have two unwrap methods to handle two different cases
-# ExecutionException(InvocationTargetExeption(SomeException))
-# InvocationTargetException(SomeException)
- Also, the parameter of these two methods should be ExecutionException or
InvocationTargetException instead of Exception.
- Pass the unwrapped exception to logProxyException. Then, isStandbyException
does not need to unwrap it again.
- Question: It seems to me that the code expects either ExecutionException or
InvocationTargetException, could we catch either ExecutionException or
InvocationTargetException instead of Exception?
- Question: the patch changes successfulProxy to lastUsedProxy. Then,
getProxy() may return "last unsuccessful proxy". Is it okay?
> RequestHedgingProxyProvider can hide Exception thrown from the Namenode for
> proxy size of 1
> -------------------------------------------------------------------------------------------
>
> Key: HDFS-12813
> URL: https://issues.apache.org/jira/browse/HDFS-12813
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: ha
> Reporter: Mukul Kumar Singh
> Assignee: Mukul Kumar Singh
> Attachments: HDFS-12813.001.patch, HDFS-12813.002.patch
>
>
> HDFS-11395 fixed the problem where the MultiException thrown by
> RequestHedgingProxyProvider was hidden. However when the target proxy size is
> 1, then unwrapping is not done for the InvocationTargetException. for target
> proxy size of 1, the unwrapping should be done till first level where as for
> multiple proxy size, it should be done at 2 levels.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
