[ 
https://issues.apache.org/jira/browse/HDFS-12759?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16257710#comment-16257710
 ] 

Hadoop QA commented on HDFS-12759:
----------------------------------

| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  9m 
33s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} HDFS-7240 Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 21m 
 3s{color} | {color:green} HDFS-7240 passed {color} |
| {color:green}+1{color} | {color:green} shadedclient {color} | {color:green} 
32m 35s{color} | {color:green} branch has no errors when building and testing 
our client artifacts. {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedclient {color} | {color:green} 
12m 56s{color} | {color:green} patch has no errors when building and testing 
our client artifacts. {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 
21s{color} | {color:green} The patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 55m 54s{color} | 
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hadoop:d11161b |
| JIRA Issue | HDFS-12759 |
| JIRA Patch URL | 
https://issues.apache.org/jira/secure/attachment/12898283/HDFS-12759-HDFS-7240.004.patch
 |
| Optional Tests |  asflicense  shadedclient  |
| uname | Linux dbfa7e435998 3.13.0-135-generic #184-Ubuntu SMP Wed Oct 18 
11:55:51 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /testptch/patchprocess/precommit/personality/provided.sh |
| git revision | HDFS-7240 / 2ed98ac |
| maven | version: Apache Maven 3.3.9 |
| Max. process+thread count | 297 (vs. ulimit of 5000) |
| modules | C: hadoop-hdfs-project/hadoop-hdfs U: 
hadoop-hdfs-project/hadoop-hdfs |
| Console output | 
https://builds.apache.org/job/PreCommit-HDFS-Build/22134/console |
| Powered by | Apache Yetus 0.7.0-SNAPSHOT   http://yetus.apache.org |


This message was automatically generated.



> Ozone: web: integrate configuration reader page to the SCM/KSM web ui.
> ----------------------------------------------------------------------
>
>                 Key: HDFS-12759
>                 URL: https://issues.apache.org/jira/browse/HDFS-12759
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: ozone
>    Affects Versions: HDFS-7240
>            Reporter: Elek, Marton
>            Assignee: Elek, Marton
>            Priority: Trivial
>              Labels: web-ui
>         Attachments: HDFS-12759-HDFS-7240.001.patch, 
> HDFS-12759-HDFS-7240.003.patch, HDFS-12759-HDFS-7240.004.patch, 
> HDFS-12759-HDFS-7280.002.patch, after1.png, after2.png, before1.png, 
> before2.png, conf.png
>
>
> In the current SCM/KSM web ui the configuration are
>  *  hidden under the Common Tools menu
>  * opens a different type of web page (different menu and style).
> In this patch I integrate the configuration page to the existing web ui:
> From user point of view:
>  * Configuration page is moved to a separated main menu
>  * The menu of the Configuration page is the same as all the others
>  * Metrics are also moved to separatad pages/menus
>  * As the configuraiton page requires full width, all the pages use full 
> width layout
> From technical point of view:
>  * To support multiple pages I enabled the angular router (which has already 
> been added as component)
>  * Not, it's suppored to create multiple pages and navigate between them, so 
> I also moved the metrics pages to different pages, making the main overview 
> page more clean.
>  * The layout changed to use the full width.
> TESTING:
> It's a client side only change. The easiest way to test is doing a full 
> build, start SCM/KSM and check the menu items
>  
>  * All the menu items should work
>  * Configuration page (from the main menu) should use the same header
>  * The configuration item of the Common tools menu shows the good old raw 
> configuration page



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

Reply via email to