[ 
https://issues.apache.org/jira/browse/HDFS-12893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16279405#comment-16279405
 ] 

Íñigo Goiri commented on HDFS-12893:
------------------------------------

Thanks [~virajith], I would change 
{{ProvidedStorageMap#getDatanodeDescriptor()}} to something a little more 
descriptive and move out the logic to check the regular DN case.
I would also include a javadoc there.

> [READ] Support replication of Provided blocks with non-default topologies.
> --------------------------------------------------------------------------
>
>                 Key: HDFS-12893
>                 URL: https://issues.apache.org/jira/browse/HDFS-12893
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>            Reporter: Virajith Jalaparti
>            Assignee: Virajith Jalaparti
>         Attachments: HDFS-12893-HDFS-9806.001.patch
>
>
> {{chooseSourceDatanodes}} returns the {{ProvidedDatanodeDescriptor}} as the 
> source of Provided blocks. As this isn't a physical datanode and doesn't 
> exist the topology, {{ReplicationWork.chooseTargets}} might fail depending on 
> the chosen {{BlockPlacementPolicy}} implementation. This JIRA aims to fix 
> this issue.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

Reply via email to