[ https://issues.apache.org/jira/browse/HDFS-12818?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16281093#comment-16281093 ]
Konstantin Shvachko commented on HDFS-12818: -------------------------------------------- Looks like a good rework of {{SimulatedFSDataset}} to allow multiple storages, which should be a useful tool for testing and benchmarking. My only concern is whether {{getBlockMap(b, bpid)}} and {{getStorage(b)}} can return null. You use them without checking null, like: {code} getStorage(theBlock).getStorageUuid(); getBlockMap(b, bpid).get(b); {code} So you can get NPE if it returns null. I see old code has null checks, at least in some cases. Also the bot found 1 new style warning. Cannot see what it is. > Support multiple storages in DataNodeCluster / SimulatedFSDataset > ----------------------------------------------------------------- > > Key: HDFS-12818 > URL: https://issues.apache.org/jira/browse/HDFS-12818 > Project: Hadoop HDFS > Issue Type: Improvement > Components: datanode, test > Reporter: Erik Krogen > Assignee: Erik Krogen > Priority: Minor > Attachments: HDFS-12818.000.patch, HDFS-12818.001.patch > > > Currently {{SimulatedFSDataset}} (and thus, {{DataNodeCluster}} with > {{-simulated}}) only supports a single storage per {{DataNode}}. Given that > the number of storages can have important implications on the performance of > block report processing, it would be useful for these classes to support a > multiple storage configuration. -- This message was sent by Atlassian JIRA (v6.4.14#64029) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org