[ 
https://issues.apache.org/jira/browse/HDFS-2058?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13047311#comment-13047311
 ] 

Todd Lipcon commented on HDFS-2058:
-----------------------------------

bq.  If you think this patch is ready for review, I will review it.

It's not "polished" as much as I'd like - eg each of the protobufs should have 
a nice bit of doc explaining when it's sent, and there's a little 
refactoring/moving of classes that could be done.

But, if you want to review it for the overall content and not "polish", it 
should be fine to start on it now. I can post cleanup as a diff. Or, we could 
even commit it and then clean up and improve docs as a followup, since let's be 
honest - it's not that clean as it stands now :) Committing this quicker rather 
than slower will also save a lot of time. As you know, patches like this fall 
out of date fast and the merges are a pain.

bq. How about filing jiras for the other HDFS protocols/issues so we get a 
sense of the scope of the remaining effort?

Sure. I have an idea what I would tackle next. The nice thing is that this can 
be done incrementally -- ie it's OK to use the existing RPC for calls to the NN 
and use protobuf for data transfer. The two protocols are non-overlapping, and 
there is benefit even at the "half done" state.

> DataTransfer Protocol using protobufs
> -------------------------------------
>
>                 Key: HDFS-2058
>                 URL: https://issues.apache.org/jira/browse/HDFS-2058
>             Project: Hadoop HDFS
>          Issue Type: New Feature
>    Affects Versions: 0.23.0
>            Reporter: Todd Lipcon
>            Assignee: Todd Lipcon
>             Fix For: 0.23.0
>
>         Attachments: hdfs-2058.txt, hdfs-2058.txt, hdfs-2058.txt
>
>
> We've been talking about this for a long time... would be nice to use 
> something like protobufs or Thrift for some of our wire protocols.
> I knocked together a prototype of DataTransferProtocol on top of proto bufs 
> that seems to work.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to