[
https://issues.apache.org/jira/browse/HDFS-12966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16311914#comment-16311914
]
Xiaoyu Yao commented on HDFS-12966:
-----------------------------------
Thanks [~shashikant] for working on this. The latest patch looks good to me
overall. Here are a few comments:
Ozone.proto
Can you elaborate on the reason to change owner from a enum (protobuf) to any
string? I can think of this is needed if we need support more than one Cblock,
KSM or NN servers to share the same SCM cluster?
CBlockManager.java
Line 127: The cblockID should be a const (initialized and persisted once per
cblock server) to represent containers owned as cblock instead of random UUID
changed upon each cblock server restart.
CreateContainerHandler.java
Line 5: Apache license header was changed unexpectedly with batch replacement.
> Ozone: owner name should be set properly when the container allocation happens
> ------------------------------------------------------------------------------
>
> Key: HDFS-12966
> URL: https://issues.apache.org/jira/browse/HDFS-12966
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: HDFS-7240
> Affects Versions: HDFS-7240
> Reporter: Shashikant Banerjee
> Assignee: Shashikant Banerjee
> Fix For: HDFS-7240
>
> Attachments: HDFS-12966-HDFS-7240.001.patch,
> HDFS-12966-HDFS-7240.002.patch, HDFS-12966-HDFS-7240.003.patch
>
>
> Currently , while the container allocation happens, the owner name is
> hardcoded as "OZONE".
> It should be set to KSM instance id/ CBlock Manager instance Id from where
> the container creation call happens.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
