[ https://issues.apache.org/jira/browse/HDFS-13036?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Chen Liang updated HDFS-13036: ------------------------------ Resolution: Fixed Fix Version/s: 3.1.0 Status: Resolved (was: Patch Available) > Reusing the volume storage ID obtained by replicaInfo > ----------------------------------------------------- > > Key: HDFS-13036 > URL: https://issues.apache.org/jira/browse/HDFS-13036 > Project: Hadoop HDFS > Issue Type: Improvement > Components: datanode > Affects Versions: 3.1.0 > Reporter: liaoyuxiangqin > Assignee: liaoyuxiangqin > Priority: Major > Fix For: 3.1.0 > > Attachments: HDFS-13036.001.patch > > Original Estimate: 2h > Remaining Estimate: 2h > > When i read the getBlockReports() of FsDatasetImpl class in datanode, i found > the following case code could be more simplify and need't to obtained volume > storage ID by replicaInfo again and again, because the vol id have get by > above code.Thanks. > {code:java|title=FsDatasetImpl.java|borderStyle=solid} > switch(b.getState()) { > case FINALIZED: > case RBW: > case RWR: > builders.get(b.getVolume().getStorageID()).add(b); > break; > case RUR: > ReplicaInfo orig = b.getOriginalReplica(); > builders.get(b.getVolume().getStorageID()).add(orig); > break; > case TEMPORARY: > break; > default: > assert false : "Illegal ReplicaInfo state."; > } > {code} -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org