[ https://issues.apache.org/jira/browse/HDFS-13033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16335380#comment-16335380 ]
Uma Maheswara Rao G commented on HDFS-13033: -------------------------------------------- # . \{code} * This class handles the external SPS block movements. This will assign block * movement tasks to target datanode descriptors. */ {code} Please correct this comments. # moveBlock logic seems to be duplicated. Can we refactor to keep common? # please cleanup unused imports # BlocksMovementsStatusHandler: class docs seems representing internal spa # you may want to update interfaceAudience level for new classes created # BlockMovementAttemptFinished: please add javadocs for public methods # probably we should add todo about need to maintain scheduled counts per datanode. > [SPS]: Implement a mechanism to do file block movements for external SPS > ------------------------------------------------------------------------ > > Key: HDFS-13033 > URL: https://issues.apache.org/jira/browse/HDFS-13033 > Project: Hadoop HDFS > Issue Type: Sub-task > Reporter: Rakesh R > Assignee: Rakesh R > Priority: Major > Fix For: HDFS-10285 > > Attachments: HDFS-13033-HDFS-10285-00.patch, > HDFS-13033-HDFS-10285-01.patch > > > HDFS-12911 modularization is introducing \{{BlockMoveTaskHandler}} interface > for moving the file blocks. That will help us to plugin different ways of > block move mechanisms, if needed. > For Internal SPS, we have simple blk movement tasks to target DN descriptors. > For external SPS, we should have mechanism to send \{{replaceBlock}} on > target node and have a listener to track the block movement completion. > This is the task to implement the \{{ExternalSPSBlockMoveTaskHandler}} plugin > for external SPS. -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org